search

keijiro / Smrvfx

Skinned mesh sampling with VFX Graph
The Unlicense
1.08k stars 153 forks source link

Errors on build > The type or namespace VFX....could not be found #9

Closed jBachalo closed 5 years ago

jBachalo commented 5 years ago

Plays fine in the editor. But get 16 build errors around the VfxExtra namespace Unity 2019.1.14f1

Googled but could find nothing relevant. Is it possible I am missing a Package?

example Assets\VfxExtra\SharedRandom.cs(7,26): error CS0246: The type or namespace name 'VFXOperator' could not be found (are you missing a using directive or an assembly reference?)

build_errors

keijiro commented 5 years ago

This should be fixed by upgrading to 2019.2. It will take time because I have to reconstruct the whole things to solve compatibility issues. Please don't expect that it'll be solved in a few days.

jBachalo commented 5 years ago

Thanks for quick reply!! So no way for me to get it working in 2019.1? If not, possible to get a rough idea to convert, 1 week or? Really want to use for current project.

keijiro commented 5 years ago

This issue is not directly related to the main functionality of this project (using skinned mesh renderer as a effect source in a VFX graph). I mean you can still use SkinnedMeshBaker.cs without the problem. This only reproduces in the example scene. That's why I'm not strongly motivated to fix the issue earlier.

jBachalo commented 5 years ago

Ok understood.

jBachalo commented 5 years ago

So simply removing the entire VFXextra package... Everything seems to work. No errors on build.

Interesting findings. Directx3D12 seems to perform worse than Directx3D11. Getting only 30-35 fps with Directx3D12 55 fps average with Directx3D11. https://forum.unity.com/threads/why-is-the-directx-12-renderer-slower-than-the-directx-11-renderer.416546/

keijiro commented 5 years ago

The project was updated with Unity 2018.2 in the recent commits.

jBachalo commented 5 years ago

Thanks!

On Tue, Aug 20, 2019 at 5:58 AM Keijiro Takahashi notifications@github.com wrote:

Closed #9 https://github.com/keijiro/Smrvfx/issues/9.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/keijiro/Smrvfx/issues/9?email_source=notifications&email_token=AAB4P2GFNVC2VIH6O4YZL6TQFO55RA5CNFSM4IL7JXF2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTEQUYNI#event-2569096245, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB4P2HWVJ5G7EEMZHQKHIDQFO55RANCNFSM4IL7JXFQ .

-- [c] 416.306.0036 [v] vimeo.com/bachalo [t] @eco_bach

"...all improvisation is life in search of a style."