kentik / ktranslate

System for pulling and pushing network data.
Apache License 2.0
57 stars 24 forks source link

Allow dimensions to be joined together in rollups. #769

Closed i3149 closed 3 weeks ago

i3149 commented 3 weeks ago

We have a customer request to allow rollups to merge 2 dimensions into one. For example, given the definition here:

sum,sum_bytes_in,in_bytes,aaa$$---$$bbb,ccc

dimensions aaa and bbb would be merged together into aaa---bbb. The $$ token is used to wrap the inner join token, which in the above example is ---.

@kentik-rbarnes , your thoughts too?

NOTE: this version only supports grouping 2 dimensions into 1. Is this OK or do we need to be able to merge N dimensions into 1?

kentik-rbarnes commented 3 weeks ago

so far we've only been asked to merge two dims so I think this is sufficient. until we get asked to merge three!