Refactor of NameGeneratorTests.cs - Githubissues

kesac / Syllabore

A fantasy name generator that does not use pre-made lists of names

MIT License

40 stars 2 forks source link

Refactor of NameGeneratorTests.cs #8

Closed monerofglory closed 1 year ago

monerofglory commented 1 year ago

Changes Made:

Move to using the "system under test" (sut) nomenclature
Utilise the DataRow attribute for test methods.
Reduced unnecessary calls to the NameGenerator constructor

Why does the change need to happen?

[ ] It addresses a bug
[X] It makes the library easier or more appealing to use
[X] It makes the library easier to maintain
[X] It future-proofs the library

monerofglory commented 1 year ago

Feel free to reach out if you would like me to go through any of the changes proposed.