kevinakasam / KlackEnder-Probe

Klicky / Quickdraw Probe for the Ender 3
GNU General Public License v3.0
368 stars 36 forks source link

[Feature Request] Use klickyprobe macros #14

Open Nighthawk3D opened 1 year ago

Nighthawk3D commented 1 year ago

Instead of using the macros included that aren’t really written well, utilize the existing work of the Klicky Probe macros.

This would allow for a much better user experience.

The existing macros could be updated to be much better if the rename_existing: function was utilized.

kevinakasam commented 1 year ago

Hey! There is something in the making to get the Klicky macros working with the Klack. Harry from my Discord spent some time to get all the changes done. I will link this in the instructions soon so you can chose if you want to use my very basic macros or the more advanced Klicky-Klack macros:

https://github.com/Harrypulvirenti/Klack-Probe-Macros

Nighthawk3D commented 1 year ago

I ran a diff on all of this... Its just renamed macros and the addition of one to handle manual screw adjust. Also removed z-tilt adjust which is more useful than manual screw adjust for some people. Why not just provide steps for setting up klickyprobe macros? This seems like overkill and just another set of macros to maintain vs just providing the config parts needed in the variables file.

Ordspilleren commented 1 year ago

I recently switched from using the native KlackEnder macros to the Klicky-Probe ones, and I managed to make it work without any changes to the core macros, only the standard variables. My changes to the default Klicky-Probe variables are as follows:

Obviously refer to your existing KlackEnder config and/or measurements for any specific values. The [bed_mesh] and [probe] sections additionally need to be moved to your printer.cfg and the KlackEnder config replaced with [include klicky-probe.cfg].

@kevinakasam If the above makes sense to document I am happy to open a PR.

kevinakasam commented 1 year ago

Hey @Ordspilleren That would be great! Feel free to add a Klicky Macro adaption block to the readme and then do a pull request :) Would be happy to merge it then