kewisch / gdata-provider

Provider for Google Calendar
https://addons.thunderbird.net/thunderbird/addon/provider-for-google-calendar/
Other
239 stars 32 forks source link

Support for adding conference information at event creation #664

Open MSBlueVn opened 12 months ago

MSBlueVn commented 12 months ago

Describe the problem and steps to reproduce it:

Get a meeting invite to your Google Workspace email in TB, accept it from that bar on top of the email, see if the meet link is saved.

What happened?

When accepting a meeting from the email part of TB, the event is saved to the calendar, but the meeting link to google meet is removed from the event.

What did you expect to happen?

When I accept a meeting from TB, the event would be saved correctly to the calendar. Meeting link would be saved correctly.

Anything else we should know?

kewisch commented 11 months ago

Meeting link support is read-only at the moment, I added a quick patch to at least show it recently. Unfortunately also the information that comes in doesn't provide a lot of info, I see a X-GOOGLE-CONFERENCE with the meet id. What I'd recommend is to go to your Google Calendar settings and enable the setting to automatically add invitations to your calendar. This way you don't need to accept via the email bar.

I can make this an enhancement request for write support for conference info, as far as it is possible.

MSBlueVn commented 11 months ago

The thing is, it also removes the meeting info from Google, so if I accept the invite and go to calendar I see no meet link. Is there a way to maybe use an API call in this event to accept or decline in the server directly? That way you avoid being reliant on the info that comes from Google and the buttons are just API calls in disguise.

MSBlueVn commented 11 months ago

Also, did you mean this: image because it was already on.

kewisch commented 11 months ago

Ah ok, so this also happens in the event dialog when you make a change there?

(not sure why I closed this btw, apologies)

MSBlueVn commented 11 months ago

I don't know which even dialog you are refering to, but I'll give you my full flow and tests so far:

  1. I get an email invite in thunderbird
  2. I click accept from the top of the preview of the email.
  3. I go to calendar in thunderbird, there's no meet link there.
  4. I go to Google Calendar on the web, it is also removed from there as well (but only for me, other people in that meeting still see that link on their event) I hope this helps
kewisch commented 11 months ago

Try this flow (not advocating it is ideal, but to help identify the issue):

  1. get email invite in Thunderbird
  2. Go to calendar tab, refresh calendar
  3. Find the event that you've been invited to
  4. Double click to open, then edit
  5. Change status to accepted, or make some other edit.

Alternatively, take some other even on your calendar you organized that has a conference info and edit it by changing something like the summary. Does the conf info retain?

MSBlueVn commented 11 months ago
  1. I refreshed and synced nothing appeared, had to close and reopen thunderbird in order for it to show.
  2. I do not see a way to change my attendance from the edit window, I looked in all tabs at the top, nothing regarding attendance.

I did the second thing you mentioned, edited the event from thunderbird, the meet was still there.

kewisch commented 11 months ago

Thanks. Then it would be great to see a difference in logs between these two actions. Note I think you can do right click on an event to change attendance.

I'm assuming one tries to create issues and then somehow overwrites the existing event, the other will simply take the existing event and edit it.

MSBlueVn commented 11 months ago

Strangely enough, right-clicking only works on the event I created, and not on events where I actually need to respond. I think something there is reversed. I replied to my own event as attending, and when I right-click on an event I was invited to, the option to respond is not there.

In case it helps, accepting my own invitation via the right click did not remove the meet link.

MSBlueVn commented 11 months ago

Let me know if there are any logs I can share that will help figure this out.

MSBlueVn commented 11 months ago

Hey @kewisch , how can we move this forward?