khanlab / hippunfold

BIDS App for Hippunfold (automated hippocampal unfolding and subfield segmentation)
https://hippunfold.readthedocs.io
MIT License
46 stars 12 forks source link

Naming of histologyReference2023 #254

Closed akhanf closed 1 year ago

akhanf commented 1 year ago

@jordandekraker I didn't pay attention to this when reviewing the initial PR, but the naming for this atlas could be improved. It seems nit-picky but it's something we would have to live with for some time, so I think it's not too late to finalize it (ie before paper is published, and before many people start using it)

What do you think of renaming this atlas to be histology7 instead? It is shorter, and conveys more meaning than the previous name.. or multihist7?

By the way, what about also publishing the probabilistic labels for each subfield?

jordandekraker commented 1 year ago

All good points! I slightly prefer multihist7, but have no strong opinion.

Let me know if you have a preference, and I'll create a PR

akhanf commented 1 year ago

Great! I agree multihist7 works well. Was a simple git mv and rename, so made the PR already, will merge it in since it's a straighforward PR..

jordandekraker commented 1 year ago

closed with https://github.com/khanlab/hippunfold/pull/256