Closed akhanf closed 1 year ago
All good points! I slightly prefer multihist7
, but have no strong opinion.
Let me know if you have a preference, and I'll create a PR
Great! I agree multihist7 works well. Was a simple git mv and rename, so made the PR already, will merge it in since it's a straighforward PR..
closed with https://github.com/khanlab/hippunfold/pull/256
@jordandekraker I didn't pay attention to this when reviewing the initial PR, but the naming for this atlas could be improved. It seems nit-picky but it's something we would have to live with for some time, so I think it's not too late to finalize it (ie before paper is published, and before many people start using it)
bigbrain
atlas is this is built from 7 datasets instead of the bigbrain pair of hippocampi, but this isn't apparent from the nameWhat do you think of renaming this atlas to be
histology7
instead? It is shorter, and conveys more meaning than the previous name.. ormultihist7
?By the way, what about also publishing the probabilistic labels for each subfield?