khrnchn / sedekah-je

speedrun project
https://sedekah.je
54 stars 37 forks source link

:8ball: update workflow (thanks claude) #242

Closed khrnchn closed 2 weeks ago

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sedekah-je ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:34am
khrnchn commented 2 weeks ago

ok tak @khursani8? sebab kalau aku buat new issue before merging the existing one into main, aku kena resolve conflict dekat pr baru haha

khursani8 commented 2 weeks ago

Aku takut, old issue org submit hilang, dia hanya guna from latest in case concurrent

khrnchn commented 2 weeks ago

Aku takut, old issue org submit hilang, dia hanya guna from latest in case concurrent

gg aku salah merge pr, ingatkan ni pr add masjid hahaha

khursani8 commented 2 weeks ago

Takpe bole revert commit tu

khursani8 commented 2 weeks ago

As for conflict tu, bole fikir better structure utk append, ada contoh conflict tak?

khrnchn commented 2 weeks ago
  1. create issue a
  2. create issue b before merging pr a
  3. merge pr a
  4. pr b conflict, dia jadi masjid b and masjid a same id, and the order is masjid b dulu baru masjid a

so cara aku resolve aku letak balik masjid a ke atas, then masjid b as a new entry

khursani8 commented 2 weeks ago

Ok so issue dia sbb id laa kan?

Kalau generate id based on issue number + 1000 ok? Ke mesti ikut susunan

khrnchn commented 2 weeks ago

tak sure lak kacau code ke tak, rasa macam tak. tapi conflict tu mula mula jelah masa buat issue banyak banyak haha, lepastu dah merge pr baru create new issue

khursani8 commented 2 weeks ago

Kalau ko sorg bole control flow, nti ramai contribute takut conflict plak 🤣

khursani8 commented 2 weeks ago

Dan aku igt nk tukar commiter tu instead of dari actions bot, nk tukar jd org yg submit

At least nama dia ada dkt contributer

khursani8 commented 2 weeks ago

@khrnchn image

khrnchn commented 2 weeks ago

alright thanks sani satgi aku update