search

kichikuou / xsystem35-sdl2

Multi-platform implementation of AliceSoft's System3.x game engine.
https://kichikuou.github.io/web/
GNU General Public License v2.0
57 stars 8 forks source link

Build failures in NIGHTDLL and ShSound modules #5

Closed nunuhara closed 4 years ago

nunuhara commented 5 years ago

SYSTEMCOUNTER_MAINLOOP is undefined: https://github.com/kichikuou/xsystem35-sdl2/blob/fa790cdcbd9bfea4395215496602efca7c0874b3/modules/NIGHTDLL/nt_scenario.c#L75-L80

MIX_CD is undefined: https://github.com/kichikuou/xsystem35-sdl2/blob/fa790cdcbd9bfea4395215496602efca7c0874b3/modules/NIGHTDLL/nt_sound.c#L30-L40

The ShSound module #includes "wavfile.h" and "pcmlib.h" which have been removed.

It seems NIGHTDLL is used by 夜が来る and ShSound is used by 大悪司.

kichikuou commented 5 years ago

In the emscripten branch, files under modules/ are currently unmaintained (because emscripten doesn't support shared libraries). I'm hoping to fix it someday, but it's not a high priority.

You can build the master branch if you need those modules, although it doesn't include recent bug fixes.

nunuhara commented 5 years ago

In that case, it's probably best to remove at least those two modules from the build system, since they cause a failure when following the instructions in the README.

kichikuou commented 5 years ago

Updated the build instruction. Will do code cleanup later.

kichikuou commented 4 years ago

Now these modules successfully build in emscripten branch HEAD.

nunuhara commented 4 years ago

I get the following error when building this on linux:

/usr/bin/ld: ../lib/libgraph.a(gre_blend.c.o): relocation R_X86_64_PC32 against undefined symbol `nact' can not be used when making a shared object; recompile with -fPIC

...and a bunch of variations of the same error.

Adding set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIC") in modules/CMakeLists.txt fixes the issue, but that should probably be hidden behind a conditional.

Otherwise it works great. I can finally play 大悪司 without booting a VM. Thank you!

kichikuou commented 4 years ago

Oops, 19296d9 should fix that.