search

kiliman / remix-express-vite-plugin

This package includes a Vite plugin to use in your Remix app. It configures an Express server for both development and production using TypeScript.
130 stars 9 forks source link

Fixes MiddleWareFunction type #18

Closed lsthornt closed 5 months ago

lsthornt commented 5 months ago

Given that middleware is awaited, I believe this is the correct typing for middleware functions.

I chose not to introduce a breaking change by applying consistent casing to MiddleWareFunction => MiddlewareFunction, but happy to revise/add an alias if desired.

kiliman commented 5 months ago

You're right. Thanks for the PR.

Could you update the README with the new type as well?

lsthornt commented 5 months ago

packages/remix-create-express-app/README.md is updated, did I miss an occurrence elsewhere? (Thought I grepped the whole repo)

kiliman commented 5 months ago

No, you're right... sorry, it's been a long day.