search

killme2008 / carmine-sentinel

A Clojure library designed to connect redis by sentinel, make carmine to support sentinel.
Eclipse Public License 1.0
14 stars 4 forks source link

remove-invalid-resolved-master-specs! usage #21

Open henryw374 opened 4 years ago

henryw374 commented 4 years ago

Hi,

We have a situation where the master becomes unavailable but we haven't received any sentinel event - how exactly this happens I'm not sure yet, but the effect of this is that the cached state about the master is never updated.

I see there is a fn remove-invalid-resolved-master-specs! which could resolve this, the docstring of which says Please call this periodically to keep safe. - although the readme makes no mention of it, but I guess it should? Or is there some specific scenarios this is intended for perhaps.

The other thing is that the fn catches EOFException but in the case where master is unreachable I'm getting a different exception, so need a more general catch.

Happy to do PR if wanted?

killme2008 commented 4 years ago

Sorry, the readme is not up-to-date.

Feel free to create PR.

henryw374 commented 4 years ago

Thanks. created https://github.com/killme2008/carmine-sentinel/pull/22