kingjulio8238 / Memary

The Open Source Memory Layer For Autonomous Agents
https://finetune.dev/
MIT License
1.4k stars 98 forks source link

PyPI memary integration #29

Closed kingjulio8238 closed 4 months ago

kingjulio8238 commented 5 months ago

Requirement for PyPi Integration - setup.py

kingjulio8238 commented 5 months ago

Additional edits to do before packaging:

Update the folder structure to have it as memary/memary folder - can we just rename 'src' as memary?

kevinl424 commented 4 months ago

Uploaded to TestPyPI here: https://test.pypi.org/project/memary-test/.

TODO before merging:

kevinl424 commented 4 months ago

After running python3 -m build from the root directory and starting a new virtual environment, running pip install dist/memary_test-0.1.3-py3-none-any.whl and changing the ChatAgent import to from memary.agent.chat_agent import ChatAgent (all the directory stuff would no longer be needed), the streamlit app works.

Following review

kingjulio8238 commented 4 months ago

Note: pip install dist/memary-0.1.3-py3-none-any.whl works instead of memary_test

kevinl424 commented 4 months ago

I should have told you earlier, but I think it's better to rename src as memary. There is no problem with operating codes, but the structure looks redundant. It depends on your preference. I'm fine with this structure also.

Was thinking under src may be better long term just in case we add some other module that goes along with memary, although not sure if that will happen. Prefer to keep it as it is but definitely open to changing it too.