kinsi55 / CS_BeatSaber_FocusMod

Stops you from looking at your Accuracy when you shouldnt
MIT License
8 stars 0 forks source link

-vrmode oculus issues (MP Extensions / Hide only in VR) #2

Closed Draegon366 closed 3 years ago

kinsi55 commented 3 years ago

Could you provide more details? I just downloaded Multiplayer extensions, opened a server and I could start a custom song just fine.

Draegon366 commented 3 years ago

huh... i was figuring out why i couldnt load into multi songs and ended up deleteing every mod one by one and it worked as soon as i got rid of focusmod, maybe its related to me being on "-vrmode oculus"?

kinsi55 commented 3 years ago

Shouldnt be, do you have any other multiplayer related mods installed other than multiplayer extensions? Were you hosting the server or did you join it? Was it a map that you already had?

Draegon366 commented 3 years ago

it happened no matter what, even if i was in a lobby by myself. and i tried it with only core mods and multi extension.

kinsi55 commented 3 years ago

Thats Weird. Do you have the latest version of FocusMod? (Updated today) as well as MP extensions? Also what exacly happens instead of loading into the song? Does the game freeze / crash? Does it just infinitely load?

Draegon366 commented 3 years ago

yes i have all the most recent versions. the game goes into an indefinite black screen once the game "starts" a song.

kinsi55 commented 3 years ago

I just tried it again with all combinations of HUD options I'm presented in the lobby and couldnt reproduce your issue.

Do you use Counters+? If so, any thirdparty counters that you have enabled in it? What combinations of hud options do you have on / off in the lobby?

Additonally, what is your FocusMod configuration?

Draegon366 commented 3 years ago

i dont have counters+, and tried every combination of hud options except disabling it altogether. i will try testing it again once ive finished this multi.

kinsi55 commented 3 years ago

Just removed Counters+ and tried the same thing again, also having tried "only hide in VR" on / off, still able to load into custom songs just fine. Its starting to look like it must be one of your other mods possibly conflicting.

You can see the list of mods that I use here and could possibly try and see if removing others you use resolves the issue.

Draegon366 commented 3 years ago

i have tried with only these mods and it still doesn't work, i have also noticed the hud doesn't disappear at all with "only hide in vr" on. if you're not testing on oculus, i'm now sure thats the reason it works for you. image

kinsi55 commented 3 years ago

I am indeed not testing on Oculus and dont own any Oculus headset so I have no easy way to test this, I know various people who play on an Oculus device tho, I will see if I can get one of them to try and see if they are able to replicate it and will let you know about the results.

i have also noticed the hud doesn't disappear at all with "only hide in vr" on

That is in Multiplayer? I quite honestly never tested multiplayer, so that is entirely possible, it should work fine in solo tho assuming there is no weird Oculus quirks.

Draegon366 commented 3 years ago

no, that's in singleplayer.

kinsi55 commented 3 years ago

Alright, I'll try to look into these things, thanks for making me aware.

Hexnet111 commented 3 years ago

huh... i was figuring out why i couldnt load into multi songs and ended up deleteing every mod one by one and it worked as soon as i got rid of focusmod, maybe its related to me being on "-vrmode oculus"?

I got the same thing happening to me, although I don't know if its caused by the focus mod yet.

kinsi55 commented 3 years ago

@Draegon366 @Hexnet111 Seeing as the plugin does not really work in Multiplayer anyways (And I dont think its that important there to begin with) I've made a small change which explicitly disables it for MP. Could you try and see if this resolves the issue?

FocusMod.zip

kinsi55 commented 3 years ago

Had somebody install MP extensions and FocusMod (Official release, not this modified one), he is on -vrmode oculus and could load into custom songs just fine as well, so it has to be some sort of configuration issue.

Draegon366 commented 3 years ago

that is very strange, but the modified dll does work.

kinsi55 commented 3 years ago

Alright, I guess I'll release that as an update once I figured out the hide in vr issue. Thanks for the feedback.

Draegon366 commented 3 years ago

"hide only in vr" now seems to be properly hiding it, but both inside and out of vr. I tested this with every combination of focusmod settings and it didn't change anything.

kinsi55 commented 3 years ago

but both inside and out of vr

Are you using the official Camera Plus or my modified one? Either way, it hiding in both is a result of camera plus. I'll try to find a fix.

kinsi55 commented 3 years ago

Released https://github.com/kinsi55/CS_BeatSaber_FocusMod/releases/tag/v0.1.3

Should address all issues, thanks for the help :)