kiooeht / pesterchum

Instant messaging client copying the look and feel of clients from Andrew Hussie's webcomic Homestuck.
Other
18 stars 8 forks source link

Remove animated smilies #19

Closed SunsetTech closed 11 years ago

SunsetTech commented 11 years ago

rational for removal: It doesn't work on osx having a lot of smilies breaks clients on linux due to file descriptor limits (it appears to open a copy of every smilie for every memo open, this can add up quickly) it leaks and eventually slows down clients if left on for too long

the second issue could probably be fixed in other ways but based on point 3 alone I figure it'd be better to just drop the feature altogether, I dont imagine much of anybody has it enabled

edit: ugh all of those other commits are still in there too, i really should've just done branches for everything, i'm so bad at this.

ugh i'm just gonna redo all of my pull requests tomorrow and move everything into branches