search

kivra / oauth2_client

Erlang OAuth2 Client
MIT License
73 stars 38 forks source link

Fix Authorization header for bearer token types #13

Closed nosnilmot closed 7 years ago

nosnilmot commented 7 years ago

The "Authorization: bearer ..." header for bearer token types was broken with the introduction of support for Azure OAuth, and was incorrectly set to 'Authorization: token ...'. This PR fixes that.

JYZR commented 7 years ago

Thanks, the support for bearer has been lost yes, but not in the PR related to Azure OAuth. It was in b2d6744.

JYZR commented 7 years ago

I'm sorry @nosnilmot but this did actually cause some problems for us. (Yes, we're actually sending bearer tokens with the type token.) What I did was to roll back master to what it was before I merged your PR. The commit is still there however and if you want to point to a branch I created master2 for you - but also for us to merge in when we've solved it on our end.

JYZR commented 6 years ago

FYI @nosnilmot, your changes are now in master.