Open jarosevcik opened 3 years ago
lgtm-com[bot]
commented
3 years ago This pull request introduces 10 alerts when merging 15356dc8548937d8879a6275f06188e8346fdf13 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 7 alerts when merging 0add7caa0408aa549197bb948d3ca55a83935c81 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging 034f65fc8655feaf9d9a2a1c0346ee6844ba5870 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging c09142e3752f484c2a83ac6e06ff015e1fa92cc3 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging 15e7d1ac9e92b15f8cfe9374304beab97e4f62c4 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging e3c8f58a47b90bf423f40a3ce0a4fb0abd1b0d97 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging 3896196efa51656e0aa36ad502e6088387a68878 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 9 alerts when merging 85ff458f3e5b5452fa9866721739e797ab1767fd into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging b9bf8d0167e8ce9d149260ab626133635e769ba4 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging f8d924e0aded6770a303738e277aab9f1d63edda into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
lgtm-com[bot]
commented
3 years ago This pull request introduces 8 alerts when merging ee13244f67038298b3e27c11c2871d361c42aa8c into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts:
aexvir
commented
3 years ago also... I'm totally up for having multiple commits to make this easier to review as there are two big chunks of work, first changing the models then updating the api, but right now those 5 commits we have don't really seem meaningful, so please squash/rename/split what's needed to have it clear
aexvir
commented
3 years ago and don't forget about the README.md 😅
it's still mentioning the old schema
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging aacae50a4fca2d37feffa24f26a740abf663f00d into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging 83d6fdb9124df20686e80b381d66ae28ad79d375 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging 0a7ed05ce2854ab7a083469af139eaad7db19e7a into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging cdbca69b98877225e86d977c45c3539d9a11aef1 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging 6060aecd46a629eacfe145cacb87d3c27c23cab6 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging 05ce5f0b39f54c8b46f72d9749667886aa738551 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging d4a2ed041e9163f18ab20edba692f3f9c9e10b49 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging 71e2ed5d0e7d9dc2cb91eb5d88001a83dc6fb031 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging 64083e6fb0f0e954a3d4a0f3073bc773cab72741 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging a1de85e4838c4c17cf8d8c8db0529efd969ee809 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging e26d49b08bd45aed623acd5261ec9453e3ce0395 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
3 years ago This pull request fixes 1 alert when merging a23fc3dd27c1b3b4ea153c0d39e4eed7a81d316b into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging c2d58adcb25b890be11773cf6fd27dc864ff463b into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging 4471c96680523af5d6f72848e1571246f303107c into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging b3ac6e2de7bf8e7387a009cf9567cea223a540de into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging 4604e21ba19f5d968873f79a20dfbd807ccb21c7 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.16%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.41 ⭐ | 2.38 ⭐ | -0.03 👍 |
| Method Length | 51.11 ⭐ | 52.41 ⭐ | 1.30 👎 |
| Working memory | 8.65 🙂 | 9.61 🙂 | 0.96 👎 |
| Quality | 74.09% 🙂 | 70.93% 🙂 | -3.16% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4624 | 3780 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging 2c8bb9b36a6eaa1c0d79246865c138e2c237bb27 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.16%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.41 ⭐ | 2.38 ⭐ | -0.03 👍 |
| Method Length | 51.11 ⭐ | 52.41 ⭐ | 1.30 👎 |
| Working memory | 8.65 🙂 | 9.61 🙂 | 0.96 👎 |
| Quality | 74.09% 🙂 | 70.93% 🙂 | -3.16% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4624 | 3780 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.16%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.41 ⭐ | 2.38 ⭐ | -0.03 👍 |
| Method Length | 51.11 ⭐ | 52.41 ⭐ | 1.30 👎 |
| Working memory | 8.65 🙂 | 9.61 🙂 | 0.96 👎 |
| Quality | 74.09% 🙂 | 70.93% 🙂 | -3.16% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4624 | 3780 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.16%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.41 ⭐ | 2.38 ⭐ | -0.03 👍 |
| Method Length | 51.11 ⭐ | 52.41 ⭐ | 1.30 👎 |
| Working memory | 8.65 🙂 | 9.61 🙂 | 0.96 👎 |
| Quality | 74.09% 🙂 | 70.93% 🙂 | -3.16% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4624 | 3780 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.16%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.41 ⭐ | 2.38 ⭐ | -0.03 👍 |
| Method Length | 51.11 ⭐ | 52.41 ⭐ | 1.30 👎 |
| Working memory | 8.65 🙂 | 9.61 🙂 | 0.96 👎 |
| Quality | 74.09% 🙂 | 70.93% 🙂 | -3.16% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4624 | 3780 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging f73e281cb49532c1778572b189b186356cc256c3 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.17 ⭐ | 1.21 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3808 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 81.29% ⭐ | 1.08% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging ac770b1d4927a27dce230024ddc92aea18980189 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.19 ⭐ | 1.23 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3808 | -844 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.19 ⭐ | 1.23 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3806 | -846 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging bcb68e40b58cf7ab377e0272fff96acd2091f76c into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.19 ⭐ | 1.23 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3806 | -846 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging 84ab43dbb4729c3b02baea4d2474a58665ffd465 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.19 ⭐ | 1.23 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3806 | -846 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging e61a0abf39fa93c994a9c4f012afd215a0ca6b53 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.19 ⭐ | 1.23 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3806 | -846 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging 791126c48934db97eaa75c505318b2fd8d7bf625 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
sourcery-ai[bot]
commented
2 years ago ❌ Merging this PR will decrease code quality in the affected files by 3.12%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
| Method Length | 50.96 ⭐ | 52.19 ⭐ | 1.23 👎 |
| Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
| Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 4652 | 3806 | -846 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
| test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
| test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
| test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
| test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
| test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
| test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
| test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
| zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
| zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
| zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
| zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
| zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
| zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
| zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
| zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
| zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
| zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
| zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
| zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
| zoo/repos/tasks.py | 64.90% 🙂 | 66.44% 🙂 | 1.54% 👍 |
| zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
| zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
| zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
| zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
| zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
| zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
| zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
lgtm-com[bot]
commented
2 years ago This pull request fixes 1 alert when merging eff8221198d5a24a9536536ef8f412e7c80c3957 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
This pull request introduces 8 alerts when merging 14dc725d06dfdc8cbb811f6df11cdc3c0769efe5 into 2070434f477288399149209119aeb915a39c7c0b - view on LGTM.com
new alerts: