search

kiwix / kiwix-apple

Kiwix for offline access on iOS and macOS
https://apple.kiwix.org
GNU Lesser General Public License v3.0
434 stars 69 forks source link

Functionality Issue with External Links #701

Closed DobleV55 closed 1 month ago

DobleV55 commented 1 month ago

Hello 👋🏻 ,

I've come across an issue while working on #660. When clicking on a link or button that directs to an external URL, everything seems to work fine initially. However, upon attempting to click the same link or button again, it fails to function. The expected behavior should allow repeated clicks on the same link or button, even if it directs to an external URL.

To reproduce the issue:

  1. Click on a link or button directing to an external URL.
  2. Observe that it functions correctly for the first click.
  3. Try clicking the same link or button again.

Notice that it fails to respond unless another link or button directing to an external URL is clicked in between.

kelson42 commented 1 month ago

@BPerlakiH I guess some kind of bug related to the external link management. Such links should be handled I guess like content external links

BPerlakiH commented 1 month ago

The problem is related to the local state of the "Alert" pop-up, so it should fix both the donation link and the web/content related links as well. Please see the fix here: https://github.com/kiwix/apple/pull/706

@kelson42: Do we want the same interruption when someone clicks the donation link? (as at the moment it applies to "all" external links, including the donation link).

DobleV55 commented 1 month ago

Hi @BPerlakiH, just to clarify, the donation link doesn't utilize loadURL, so it doesn't trigger an interruption when clicked. The "Support Kiwik" button uses Link() and opens directly.