search

kiwix / kiwix-apple

Kiwix for offline access on iOS and macOS
https://apple.kiwix.org
GNU Lesser General Public License v3.0
434 stars 69 forks source link

Remove Brewfile.lock.json #703

Closed BPerlakiH closed 1 month ago

BPerlakiH commented 1 month ago

Fixes #702

kelson42 commented 1 month ago

I'm not confortable -at this stage- to merge without better understanding:

I will look in details...

BPerlakiH commented 1 month ago

why it is here in a first place

It is generated by the command "brew bundle"

why it is a problem to keep it

If a new contributor to the repository follows our instructions in Readme, checks out the main branch and run "brew bundle", that will generate a newer version of this file, and it will be most probably checked in with the PR.

why we don't want to rely on fix deps

It is not working as in other tools, it won't "lock" our dependencies in any form. Eg. on CI this file is overwritten / changed during build... From what I have read, the only benefit of this file is to compare it with the former version to see what has changed, a kind of "debug"...