search

kiwix / kiwix-apple

Kiwix for offline access on iOS and macOS
https://apple.kiwix.org
GNU Lesser General Public License v3.0
434 stars 69 forks source link

Detect cmd+click event to open link on new tab #708

Closed quocduyvu6262 closed 1 month ago

quocduyvu6262 commented 1 month ago

Fixes (#540)

quocduyvu6262 commented 1 month ago

@BPerlakiH Hi, I recently joined the project and really appreciate it if you could review this PR. Thanks!

BPerlakiH commented 1 month ago

Looks good to me.

kelson42 commented 1 month ago

@quocduyvu6262 I wanted to merge but can not because current beanch has to be rebased on main branch (no merge!).

quocduyvu6262 commented 1 month ago

@quocduyvu6262 I wanted to merge but can not because current beanch has to be rebased on main branch (no merge!).

Hi @kelson42, I have recently rebased this branch on main branch. You can try to merge again. Thanks!

BPerlakiH commented 1 month ago

@kelson42 @rgaudin I think we need more approvals for this one in order to build it, and then merge it.