EPUBs - Save content of unknown mime-types

BPerlakiH commented 1 month ago

Fixes #193

Before

We had the following flow for a kiwix url (eg: kiwix://42EF661C-B328-5AFF-4A1D-41F348378AFE/I/files/9791029307393.epub)

intercept the web-browser for kiwix scheme
get the content of this url from the ZIM file (the epub data)
pass back the content to the web browser
if the browser could not open it, it was triggering an alert. The same was triggered even if the content was missing

Changes

before sending the ZIM content to the browser, make sure it exists, and has greater than 0 size, otherwise trigger the alert immediately, and do not send anything to the browser
one we get the content on the browser side, but before displaying anything, at this point we can determine if the mime-type of it was "understood" by the browser
if the mime-type was understood, we can process the request as usual
if the mime-type was not understood we offer to export the content

Exporting the content

update the user permissions to be able to export / write files
macOS:

Here it is slightly easier, once we have the content to export, we can display the "save" panel from the OS, and once the user selects where it should be saved, we can write the content there. In terms of I/O, we write the file only once directly to the place picked by the user (eg: Desktop folder)

iOS:

It is slightly more complicated, as in order to display / share the content we need to create a temporary file out of it. In order not to create accidental files just by taping on links, there's an additional alert asking the user if he/she wants to export the content. Once agreed, we create the temp file, show the system dialog, where the user can save the file, and once that is closed (either with or without success), we delete the temp file.

kelson42 commented 1 month ago

@BPerlakiH What about opening the file directly with a third party app? Here, and for this kind of UX tickets, would be great to have a small screencast in the PR description so we can figure out how it works.

BPerlakiH commented 1 month ago

@kelson42 posted the video recordings to you on slack.

kelson42 commented 1 month ago

Videos looks good. @rgaudin any remarks? I would propose to merge and test with testflight if it really work like expected?

rgaudin commented 4 weeks ago

Videos looks good. @rgaudin any remarks? I would propose to merge and test with testflight if it really work like expected?

I agree

kiwix / kiwix-apple