search

kiwix / kiwix-apple

Kiwix for offline access on iOS and macOS
https://apple.kiwix.org
GNU Lesser General Public License v3.0
448 stars 70 forks source link

Navigation history should be empty at ZIM opening time #819

Open kelson42 opened 2 weeks ago

kelson42 commented 2 weeks ago

Downloading this file: https://library.kiwix.org/#lang=&q=water+preppers&category=

Loading in Kiwix for iOS:

image

We can see that the left arrow to navigate back in the history is active, it should not

BPerlakiH commented 1 week ago

@kelson42 it seems to be a redirect issue from: kiwix://1F0E1CD1-14A2-3125-F1CD-55C318022344/home to: kiwix://1F0E1CD1-14A2-3125-F1CD-55C318022344/home#list--0

I am not sure about this to be honest. Should this be fixed on the reader side? I can only think of hacks and workarounds for this.

kelson42 commented 1 week ago

@BPerlakiH There is no elegant way to remove ZIM redirects from the navigation history?

BPerlakiH commented 1 week ago

@kelson42 There's a read only list of "backItems" added to the history, and from what I can see not really editable.

We can override at the back button level (is it enabled or not), but the user can still swipe back (at the edge of the screen) to the former page, like so: https://github.com/kiwix/kiwix-apple/assets/6784320/4296dc28-5ae9-4cf5-bded-c72825a5f198

Possibly our best option is to block the navigation in the first place, I will have a look how we could distinguish which is a redirect and which is a user initiated navigation.

kelson42 commented 1 week ago

postponing to 3.5.0