kiwix / kiwix-apple

Kiwix for iOS & macOS
https://apple.kiwix.org
GNU Lesser General Public License v3.0
493 stars 70 forks source link

iPad video subtitles pop-over is really small #915

Open BPerlakiH opened 2 months ago

BPerlakiH commented 2 months ago

The subtitles pop-over is really small (compared to the native one, which is disabled by video js).

BPerlakiH commented 2 months ago

So far the only way I have found is to adjust videojs settings in the content itself, which requires some find a replace magic on the loaded HTML content, which might or might not work...

I think we can leave this issue as is, the user can switch between subtitle languages more easily in full screen mode, only the inline one is really small.

See here:

Screenshot 2024-08-09 at 11 03 55

compared to the full screen one: Screenshot 2024-08-09 at 11 00 28

kelson42 commented 2 months ago

@BPerlakiH The bug report lack of details. You mean you would like to have the popup box to have a bigger maximum height? What do you mean with native one? Could we have clear screenshots of what you get against what you expect? @benoit74 Would that be some we could and should do in the ZIM? Report upstream to video.js?

BPerlakiH commented 2 months ago

@kelson42 here is the comparison between using the provided videojs ui on the iPad, and how it looks when we turn videojs off, and the native/system ui is used:

videojs:

https://github.com/user-attachments/assets/418c5ef2-4429-42e9-a59c-7dd17cd869c6


native:

https://github.com/user-attachments/assets/7082f84a-72ae-475c-8236-af7275d220fa

BPerlakiH commented 2 months ago

So to sum up, this is specific only to iPad, and only when the video is not in full screen, it is really hard to browse those languages, and you need to be really accurate selecting, as it's less than half of a finger size.

If the video is in full screen the subtitles can be changed without any problems. Probably it's a small issue, and might be fixed in next video js releases. (the new video ZIM provided in: #914 unfortunately has no subtitles, so couldn't use that for this purpose).

kelson42 commented 1 month ago

@benoit74 Your feedback would be welcome here about (1) "issue" assessment (2) how the solution could/should look like.

benoit74 commented 1 month ago

If I get the issue correctly, then I think that this should be reported to videoJS since a generic solution would help all users.

I don't have an iPad to test, but do we have the same issue on https://videojs.com/advanced?video=bipbop-advanced?

benoit74 commented 1 month ago

And don't we have the same issue on all small touch screens? (e.g. on my Android phone, it is not easy to be sure to spot proper language either)

kelson42 commented 1 month ago

@benoit74 Probably! To me this is an enhancement to do at videojs level and if they can't using a custom CSS to apply in our scraper(s). Therefore I would propose to:

Does that sounds appropriate?

benoit74 commented 1 month ago

Why youtube ? video.js is used in many scrapers, not only youtube.

kelson42 commented 1 month ago

Why youtube ? video.js is used in many scrapers, not only youtube.

Once fixed in youtube scraper I will request to fix in other scrapers. One issue at a time.

benoit74 commented 1 month ago

But this issue speaks about a problem in TED ...

kelson42 commented 1 month ago

@benoit74 Oui, so move to openzim/ted. Does that change anything at the end (i believe all our scrapers are impacted in the manner, or isn't it the case)?

benoit74 commented 1 month ago

All scrapers relying on video.js are probably impacted in the same manner indeed

kelson42 commented 3 weeks ago

Assigning to @benoit74 as this is something which might be improved at scraper level. Moving to next milestone.

benoit74 commented 3 weeks ago

I have opened https://github.com/videojs/video.js/discussions/8892 to start the discussion at video.js side.

That been said, I don't get why once in fullscreen you have a kind of different player. I don't have the same behavior on Android in my browser or in the app. Is this something specific to kiwix-apple?