search

kiwix / kiwix-apple

Kiwix for iOS & macOS
https://apple.kiwix.org
GNU Lesser General Public License v3.0
470 stars 70 forks source link

Not all chinese characters are rendered properly #919

Open RuochenFu21 opened 1 month ago

RuochenFu21 commented 1 month ago

I'm often wonder around Wiktionary for CJKV Characters, and one of the issues is the typeface default on iOS doesn't support the wide amount of CJKV Characters. So it would be great if we can import fonts like Noto Sans CJK that have a wider character set to the reader.

kelson42 commented 1 month ago

This is the role of the ZIM content to provide the proper font if needed, not the role of the reader. If you think there is a problem around a font on a ZIM, you can report it at https://github.com/openzim/zim-requests.

RuochenFu21 commented 1 month ago

This is the role of the ZIM content to provide the proper font if needed, not the role of the reader. If you think there is a problem around a font on a ZIM, you can report it at https://github.com/openzim/zim-requests.

I think adding it to the reader would make more sense. Because since this is for offline, and the zim file for Wiktionary is not specifically for CJKV languages. Making it a part of the zim file would require everyone to download the font needed to view CJKV characters, even for people that didn't download the Wiktionary zim file for any language that needed the font.

RuochenFu21 commented 1 month ago

And adding it to the zim file would cause some inconsistency for people on Android since I believe they got support for a larger character set, and a different font for an app when its not set by the user might be a bit questionable

kelson42 commented 1 month ago

@RuochenFu21 Can you please share here which ZIM fike exactly? Which artivle exactly and what is wrongly displayed (a screenshot woukd be helpful)?

RuochenFu21 commented 1 month ago

Wiktionary downloaded on 2024 January Second. IMG_1591BB2E50DB-1

kelson42 commented 1 month ago

@RuochenFu21 Can you please put link to online article, so we can compare?

RuochenFu21 commented 1 month ago

@RuochenFu21 Can you please put link to online article, so we can compare?

There isn't a big difference. The page is displayed correctly in some sense since it's displaying the same thing as the web page. However, you can say that the default display on the web page isn't optimal due to the fact that it uses characters that default on iOS doesn't support.

For the reason that only iOS doesn't support those characters, other platforms could render it fine. Adding it to the .zim file wouldn't make much sense for people reading on other more compatible platforms.

To conclude, adding user specified fonts as an option would optimize such a page with technical issues which only affects a portion of the users that requires fonts with bigger character sets due to the small character set that Apple provides that is not able to be changed on iOS without JailBreaking.

RuochenFu21 commented 1 month ago

And anyways being able to change the default font on a reader is a good feature to have. This isn't necessarily an error, but I do believe adding such an option would optimize a lot of users' experience on the app. Even for other people that doesn't require bigger character set but actually prefer a different font.

kelson42 commented 1 month ago

Without the article name I can not reproduce the issue and I won't fix an issue I can not reproduce.

RuochenFu21 commented 1 month ago

This is the article I mentioned: https://zh.wiktionary.org/wiki/%F0%A0%A4%AA

kelson42 commented 1 week ago

@BPerlakiH That looks like a bug in the font we use on ioS?!