search

klarna-incubator / webtraversallibrary

The Web Traversal Library (WTL) is a Python library for abstracting web interactions on top of a base execution layer such as Selenium.
Apache License 2.0
71 stars 7 forks source link

Removed XPATH generation, noone cares #150

Closed naslundx closed 3 years ago

naslundx commented 3 years ago

Fixes (ish) #137

XPATH selector isn't supported anywhere else in WTL, so doesn't really make sense to support it. Let's add back support in the future (across the board) if needed.

redfungus commented 3 years ago

Hi! We actually use the xpath selector quite a lot. Is this open for reconsidering?

naslundx commented 3 years ago

@redfungus Oh, I didn't know! How do you use it exactly? There is no actual support inside WTL

redfungus commented 3 years ago

@redfungus Oh, I didn't know! How do you use it exactly? There is no actual support inside WTL

We just read it to use as features to compare distances between DOM elements. It can technically also be done with the css selector with some changes.

naslundx commented 3 years ago

Upon request I will redo this so that xpath field is still generated but readonly.