search

klarna-incubator / webtraversallibrary

The Web Traversal Library (WTL) is a Python library for abstracting web interactions on top of a base execution layer such as Selenium.
Apache License 2.0
71 stars 7 forks source link

version_check on Windows: FileNotFoundError #169

Closed apikas closed 3 years ago

apikas commented 3 years ago

I ran v0.12.0 on Windows 10, and got an exception that was not caught in version_check.py, line 28: FileNotFoundError. I fixed it like this: except (CalledProcessError, FileNotFoundError):

All other Windows issues that I had in 0.11 seem to have been fixed 🥇

vonNiklasson commented 3 years ago

Thank you @apikas for the issue report and the fix/workaround, I will look into this as soon as I get hold on a Windows computer :)

Cheers Johan

vonNiklasson commented 3 years ago

Hello again @apikas! Just wanted to let you know that a fix is in progress for this. For reference it also affects Mac users.

Cheers!

apikas commented 3 years ago

Glad to hear that you can perform testing on both Linux, Mac and Windoze! I try to stick to the first 2, but sometimes the environment requires otherwise...

vonNiklasson commented 3 years ago

Hello again @apikas!

I'm just letting you know that the issue is fixed and will be shipped in next version (0.13.0) which will be released later today 🎉