search

klarna-incubator / webtraversallibrary

The Web Traversal Library (WTL) is a Python library for abstracting web interactions on top of a base execution layer such as Selenium.
Apache License 2.0
71 stars 7 forks source link

Put back the internal logging module as fallback #193

Closed vonNiklasson closed 2 years ago

vonNiklasson commented 3 years ago

Put back the webtraversallibrary.logging module for backwards compatibility, as well as a fix for editors who tries to import the webtraversallibrary.logging module locally at runtime.

naslundx commented 3 years ago

Why the fallback? When would the other logger fail?

vonNiklasson commented 3 years ago

Why the fallback? When would the other logger fail?

It's basically just to ensure backwards compatibility, hence why it refers to the logging_utils module.

vonNiklasson commented 3 years ago

Also, the reason for the change from logging to logging_utils were because some IDE's and editors had trouble differentiating between the built in logging module and this one (probably had something to do with the order of updating the pythonpath and unspecified referencing from the IDE). Not a runtime issue though.

naslundx commented 2 years ago

Wanna rebase this, sir?

vonNiklasson commented 2 years ago

Don't mind if I do

vonNiklasson commented 2 years ago

Turns out I don't have write access anymore since I seceded my permissions to this repo a while ago. I could of course fork and do a PR, but would you mind rebasing this for me just this once @naslundx?

vonNiklasson commented 2 years ago

LGTM! 🎈