search

kloder-games / godot-admob

Module Admob for Godot engine
MIT License
360 stars 61 forks source link

[ERROR]The application is loading the banner even without being activated #124

Closed gumaciel closed 4 years ago

gumaciel commented 4 years ago

OS target (Android/iOS): iOS

Godot version: 3.2/3.2.1

Issue description: The app is loading banner without i ask to it

Log:

2020-04-11 11:33:01.877859-0400 testAdmob[11322:3035191] Reward based video ad is received. 2020-04-11 11:33:01.896072-0400 testAdmob[11322:3035191] Rewarded loaded success 2020-04-11 11:33:02.546929-0400 testAdmob[11322:3035191] Calling showRewardedVideo 2020-04-11 11:33:02.547115-0400 testAdmob[11322:3035191] Calling disableBanner 2020-04-11 11:33:02.547965-0400 testAdmob[11322:3035191] Opened reward based video ad. 2020-04-11 11:33:03.236749-0400 testAdmob[11322:3035191] Reward based video ad started playing. 2020-04-11 11:33:04.254181-0400 testAdmob[11322:3035191] banner enable call 2020-04-11 11:33:04.254493-0400 testAdmob[11322:3035191] Calling enableBanner 2020-04-11 11:33:04.254576-0400 testAdmob[11322:3035191] Calling loadBanner 2020-04-11 11:33:04.920821-0400 testAdmob[11322:3035191] adViewDidReceiveAd (lldb)

Every time the reward or interstitial ad appears, it loads the banner at the end, and this ALWAYS causes an error

image

gumaciel commented 4 years ago

@Shin-NiL @yamshing @GhostWalker562

any idea what this could be?

gumaciel commented 4 years ago

i forgot to show the error on Xcode

image

GhostWalker562 commented 4 years ago

Is the AdMob module fully updated? It seems that somewhere in the rewarded video code it must’ve called enableBanner and caused them to stack on a single thread which is a known issue to crash

gumaciel commented 4 years ago

hi @GhostWalker562 yes, i search on the file code and i think these methods are causing the error

https://github.com/kloder-games/godot-admob/blob/caaad6dac7b3a02a85dc109140551a67c50b2cb8/admob/ios/src/AdmobRewarded.mm#L81

https://github.com/kloder-games/godot-admob/blob/caaad6dac7b3a02a85dc109140551a67c50b2cb8/admob/ios/src/AdmobInterstitial.mm#L87

GhostWalker562 commented 4 years ago

Well, I can't really help then sorry. I would say however that the NSLogs are missing so I'm not sure whether it's actually those methods that are causing troubles.