search

kloder-games / godot-admob

Module Admob for Godot engine
MIT License
360 stars 61 forks source link

[BUG] 3.2.1 Crashes on initialize AdmobInterstitial #126

Closed gumaciel closed 4 years ago

gumaciel commented 4 years ago

OS target (Android/iOS): iOS

Godot version: 3.2.1

Issue description: image

I downloaded the compiled from:

https://github.com/GhostWalker562/godot-admob-iOS-precompiled/releases

cemeai commented 4 years ago

did a rollback of an update described here https://github.com/kloder-games/godot-admob/issues/123

at file admob/ios/src/godotAdmob.mm

interstitial = [AdmobInterstitial alloc]; [interstitial initialize:isReal :instanceId :banner];

// official version interstitial = [[AdmobInterstitial alloc] init]; [interstitial initialize:isReal :instanceId]; // :banner not passed

rewarded = [AdmobRewarded alloc]; [rewarded initialize:isReal :instanceId :banner];

//official version rewarded = [[AdmobRewarded alloc] init]; [rewarded initialize:isReal :instanceId]; // :banner not passed

check what version is the compiled version you have, you may have the old version. I am trying 3.1 prob why i had to rollback the update. since you are in 3.2 you may need the official and have the old one

gumaciel commented 4 years ago

Ty, in a few days i will try it and give a feedback

gumaciel commented 4 years ago

Did you encounter this error?

https://github.com/kloder-games/godot-admob/issues/124

cemeai commented 4 years ago

haven't sorry

Sajyd commented 4 years ago

I'm having the same issue. Compiled iOS export template from 3.2.1-stable source and followed readme instruction still had this issue. Any idea what could be wrong ? I'm sure I initialized it well.

Sajyd commented 4 years ago

Finally managed to make it work by recompiling with old code

gumaciel commented 4 years ago

Finally managed to make it work by recompiling with old code

@Sajyd can you please upload the file to i test?

gumaciel commented 4 years ago

Resolved on https://github.com/kloder-games/godot-admob/pull/128, thanks @minhanhhere