search

knupfer / haskell-emacs

Write Emacs extensions in Haskell
375 stars 22 forks source link

Extend exports discovery to include omitted export specification. #19

Closed ExternalReality closed 9 years ago

ExternalReality commented 9 years ago

All defined functions in a module should be found by haskell-emacs when export specification is absent from module header.

ExternalReality commented 9 years ago

All good catches, will fix.

ExternalReality commented 9 years ago

Catches were fixed. Please advise.

knupfer commented 9 years ago

Thanks for your aide! I'll review it untill the weekend.

knupfer commented 9 years ago

I've merged, with some modifications, it finally worked on my side. There is only one problem I can see. Your blog example won't work because of the language pragma. Basically, it is now much more robust but can't handle pragmas...

knupfer commented 9 years ago

I've fixed the language issue

ExternalReality commented 9 years ago

Hey Knupfer, that you for handling that. Its great that it all worked out.

knupfer commented 9 years ago

It's great to work with your code, I've learned a lot!

Eric notifications@github.com writes:

Hey Knupfer, that you for handling that. Its great that it all worked out.

--- Reply to this email directly or view it on GitHub: https://github.com/knupfer/haskell-emacs/pull/19#issuecomment-131402999