kobuki-base / kobuki_ros

ROS2 runtime libraries, nodes and launchers for the Kobuki
46 stars 27 forks source link

Fix build on foxy and remove unused dependencies #10

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

The std::move call in odometry.cpp caused build error against Foxy

odometry.cpp:135:19: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move] 

Additionally, removing exec_depends that aren't used (and cause build issues right now)

stonier commented 4 years ago

LGTM.