Closed emersonknapp closed 4 years ago
The std::move call in odometry.cpp caused build error against Foxy
std::move
odometry.cpp:135:19: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
Additionally, removing exec_depends that aren't used (and cause build issues right now)
exec_depend
diagnostic_aggregator
kobuki_ftdi
kobuki_driver
kobuki_keyop
kobuki_safety_controller
LGTM.
The
std::move
call in odometry.cpp caused build error against FoxyAdditionally, removing
exec_depend
s that aren't used (and cause build issues right now)diagnostic_aggregator
- there are not yet ros2 launchfiles in this project, therefore this isn't really a runtime dependency yetkobuki_ftdi
- all of the kobuki communication is handled by thekobuki_driver
dependency chainkobuki_keyop
- the driver node should not know about teleop as a mandatory dependency (also not used anywhere yet)kobuki_safety_controller
- not used anywhere