search

kobuki-base / kobuki_ros

ROS2 runtime libraries, nodes and launchers for the Kobuki
46 stars 27 forks source link

Small fixes for Rolling. #24

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@stonier These fixes get rid of warnings while building against Rolling. They only apply to Rolling; we can't release them into Galactic or Foxy. I'm not sure how we should handle this in this repositories branching scheme.

clalancette commented 2 years ago

Actually, it is slightly more complicated. It turns out that we need these fixes for both Galactic and Rolling, while they do not work on Foxy. So I think the thing to do here is to do a release where we branch off for Foxy before these fixes, then merge these changes in.

That said, I'm going to hold off on that for a little while longer so that I can do a bit more porting of the remaining bits to ROS 2. Once that is done, I'll probably go ahead and make a releases/1.1.x branch and a 1.1.0 tag for Foxy, and then merge this into the devel branch for Galactic and Rolling.

clalancette commented 2 years ago

All right, with all of the recent work in, I've now done a release for Foxy into the release/1.1.x branch with tag 1.1.0. That means that we can now merge this into devel for Galactic and Rolling.