search

kobuki-base / kobuki_ros

ROS2 runtime libraries, nodes and launchers for the Kobuki
46 stars 27 forks source link

fixed kobuki_description #35

Closed wn1980 closed 2 years ago

wn1980 commented 2 years ago

I have fixed the kobuki_description and tested it on Ubuntu amd64 and arm64. I hope that this will be useful for visualization as well as Gazebo simulation.

wn1980 commented 2 years ago

Yes, I prefer to add the BSD license to robot_description.launch.py. By the way, could please do this for me in the merging step?

clalancette commented 2 years ago

Yes, I prefer to add the BSD license to robot_description.launch.py. By the way, could please do this for me in the merging step?

I'd prefer if you did it. That way there is no question of who added the license later on. You can just copy the header from https://github.com/kobuki-base/kobuki_ros/blob/devel/kobuki_safety_controller/launch/safety_controller-composed-launch.py , change the Copyright line to your name, and that should be enough to pass the linters.

wn1980 commented 2 years ago

@clalancette I have already added the license and pushed it into my repos. Could you proceed ahead?

wn1980 commented 2 years ago

@clalancette In addition, I also added the same license to kobuki_auto_docking/launch/compact.launch.py.