search

kobuki-base / kobuki_ros

ROS2 runtime libraries, nodes and launchers for the Kobuki
46 stars 27 forks source link

WIP: Port the kobuki node to ROS 2. #4

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This one is hot off the presses. I just got the basic code to compile; I've done no testing, and haven't ported over the config or launch files yet. I thought I'd open it just so you can see what I've done here so far.

clalancette commented 4 years ago

was there anything significant there you'd like me to check?

The most significant thing was the refactor of that Odometry class, which you've already commented on. I'll take a look at your suggestions there and see if I can make it more palatable.

clalancette commented 4 years ago

Based on the last comment, I'm going to merge this, then do follow-up PRs to get stuff actually working.