kobuki-base / kobuki_ros

ROS2 runtime libraries, nodes and launchers for the Kobuki
46 stars 27 forks source link

Galactic/Rolling release #41

Open fpasch opened 2 years ago

fpasch commented 2 years ago

Would you be able to provide a release for ROS2 galactic and rolling? It's already building and running successfully with a local build. So it would only be the release that is missing. Thanks :-)

clalancette commented 2 years ago

So I have the permissions and ability to do releases here.

Unfortunately, the big blocker here is the release of sophus and the ecl set of libraries, which these libraries depend on. I don't have permissions there, so we can't release right now. Maybe we can convince @stonier to release sophus and ecl libraries, though.

fpasch commented 2 years ago

Sounds good.

I already added a comment in https://github.com/stonier/ecl_core/issues/112

stonier commented 2 years ago

Maybe we can convince @stonier to release sophus and ecl libraries, though.

Convinced. I'll update when done.

clalancette commented 2 years ago

Convinced. I'll update when done.

Thanks Daniel!

wn1980 commented 2 years ago

I have installed this ros2 kobuki driver on Galactic by building from source. Please adjust this script for your system.

stonier commented 2 years ago

Forgot to update.

ljaniec commented 2 years ago

Please write if there is any help needed, I am interested in these packages released

igrak34 commented 2 years ago

I'm also looking forward to humble releases.

ljaniec commented 2 years ago

@stonier Hello, are these problems

https://github.com/stonier/ecl_core/issues/113

the ones that block the release on Humble?

dcconner commented 2 years ago

I created some forks that did the minimum fixes to build and work on Humble, mostly by disabling some of the tests. I have the following source building and running on a Turtlebot 2 under ROS Humble.

I don't claim the fixes are "correct", just that they got me up and running

wn1980 commented 2 years ago

@dcconner I tested your code. It turns out that it can be built on amd64 but fails on arm64. Have you attempted to compile on arm64, such as the Jetson Nano board?

dcconner commented 2 years ago

@wn1980 I only did the minimum in those forks to allow me to compile on Intel i7 and i5 systems with Ubuntu 22.04 and ROS Humble. So while deserving of a "side eye" from @ljaniec , I shared in hopes of accelerating testing and progress for those waiting on correct updates. I don't plan on issuing any pull requests because those changes just hiding some build issues, not fixing them.

ljaniec commented 2 years ago

@dcconner My intention was not "side eye" with any derogatory meaning, sorry if that may have been your understanding. That was not what I was thinking, rather I was "looking into it" with interest. I couldn't find any reasonable documentation on ecl packages, especially the failed concept checks, so I'm no help for now either.

ljaniec commented 1 year ago

It looks like @stonier made some recent updates to the ecl libraries, it is worth a shot to check everything again