:seedling: Remove `APIClient`, update effected rest functions

konveyor / tackle2-ui

Tackle (2nd generation) UI component.

Apache License 2.0

8 stars 43 forks source link

Closed sjd78 closed 7 months ago

sjd78 commented 7 months ago

Changes:

Remove APIClient
Update the affected functions in rest.ts to use axios directly
Double check the return types of the effected functions
Updated a few API model types based on current hub handler function responses
getApplicationSummaryCSV() URL query param was incorrectly named and could lead to more results returned than expected. Query param updated to the correct name as per the OpenAPI definition / golang handler code.

Resolves: #1821 Part-of: #1411

sjd78 commented 7 months ago

Looks good. The case of param name importSummary.id (and why it worked before!) is worth documenting but I leave it to you.

It ~~worked~~ didn't fail before because the query param is not required.