konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:bug: Fix effort width & visibility conditional removed in app table #1947

Closed ibolton336 closed 5 months ago

ibolton336 commented 5 months ago

Noticed some odd behavior in the app table.

Width and column visibility conditional removed from the effort col here: https://github.com/konveyor/tackle2-ui/pull/1846/files#diff-7215462f9c61fbbe2362b5f02a64aa2f56a9b6b47fab387f8a7e9c5819c92a8eL848

Before:

image

After:

Screenshot 2024-06-07 at 10 58 22 AM

This PR fixes these regressions in the app table and replaces custom tooltips with the tooltip behavior included within the component via the info prop.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.16%. Comparing base (b654645) to head (1fc683a). Report is 157 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1947 +/- ## ========================================== + Coverage 39.20% 42.16% +2.96% ========================================== Files 146 166 +20 Lines 4857 5320 +463 Branches 1164 1330 +166 ========================================== + Hits 1904 2243 +339 - Misses 2939 3061 +122 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1947/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1947/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.16% <ø> (+2.96%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1947/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.