Closed rszwajko closed 3 weeks ago
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 42.16%. Comparing base (
b654645
) to head (fedd078
). Report is 156 commits behind head on main.:exclamation: Current head fedd078 differs from pull request most recent head ab0ca70
Please upload reports for the commit ab0ca70 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
...ponents/FilterToolbar/MultiselectFilterControl.tsx | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Addresses issue #1944 introduced by #1903 (follow-up to #1946)
The MultiselectFilterControl component discovers groups from provided data. Each group results in a new ToolbarFilter/ChipGroup pair. Before this fix, the keys were based only on group names. In case of Language filter it created a collision with Language group derived from Tags. After this fix, the keys are built by concatenating category title and group name. The category title is known at compile time and is expected to be unique among all filters on the screen.
Reference-Url: https://github.com/konveyor/tackle2-ui/issues/1944 Reference-Url: https://github.com/konveyor/tackle2-ui/pull/1903 Reference-Url: https://github.com/konveyor/tackle2-ui/pull/1946