konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
6 stars 29 forks source link

:bug: Provide unique keys for components in MultiselectFilterControl #1949

Closed rszwajko closed 3 weeks ago

rszwajko commented 3 weeks ago

Addresses issue #1944 introduced by #1903 (follow-up to #1946)

The MultiselectFilterControl component discovers groups from provided data. Each group results in a new ToolbarFilter/ChipGroup pair. Before this fix, the keys were based only on group names. In case of Language filter it created a collision with Language group derived from Tags. After this fix, the keys are built by concatenating category title and group name. The category title is known at compile time and is expected to be unique among all filters on the screen.

Reference-Url: https://github.com/konveyor/tackle2-ui/issues/1944 Reference-Url: https://github.com/konveyor/tackle2-ui/pull/1903 Reference-Url: https://github.com/konveyor/tackle2-ui/pull/1946

rszwajko commented 3 weeks ago

Screenshot from 2024-06-08 16-52-15

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.16%. Comparing base (b654645) to head (fedd078). Report is 156 commits behind head on main.

:exclamation: Current head fedd078 differs from pull request most recent head ab0ca70

Please upload reports for the commit ab0ca70 to get more accurate results.

Files Patch % Lines
...ponents/FilterToolbar/MultiselectFilterControl.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1949 +/- ## ========================================== + Coverage 39.20% 42.16% +2.96% ========================================== Files 146 166 +20 Lines 4857 5320 +463 Branches 1164 1330 +166 ========================================== + Hits 1904 2243 +339 - Misses 2939 3061 +122 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1949/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1949/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.16% <0.00%> (+2.96%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1949/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.