konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
6 stars 29 forks source link

:sparkles: [AnalysisWizard] Language discovery changes #1951

Closed ibolton336 closed 1 week ago

ibolton336 commented 3 weeks ago

Resolves https://github.com/konveyor/tackle2-ui/issues/1950

UI Tests PR: 1136

Needs: https://github.com/konveyor/tackle-ui-tests/pull/1136

Includes:

Screenshot 2024-06-12 at 3 37 47 PM
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 12.30769% with 57 lines in your changes missing coverage. Please review.

Project coverage is 42.73%. Comparing base (b654645) to head (cc9a731). Report is 165 commits behind head on main.

Files Patch % Lines
client/src/app/components/SimpleSelectCheckbox.tsx 10.52% 34 Missing :warning:
...pages/applications/analysis-wizard/set-targets.tsx 13.63% 19 Missing :warning:
...ent/src/app/components/target-card/target-card.tsx 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1951 +/- ## ========================================== + Coverage 39.20% 42.73% +3.53% ========================================== Files 146 166 +20 Lines 4857 5258 +401 Branches 1164 1299 +135 ========================================== + Hits 1904 2247 +343 - Misses 2939 2995 +56 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1951/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.73% <12.30%> (+3.53%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjd78 commented 2 weeks ago

e2e ui testing is failing: https://github.com/konveyor/tackle2-ui/actions/runs/9504942845/job/26198861030?pr=1951#step:10:1822

ibolton336 commented 2 weeks ago

First look makes sense, but there is an inconsistency with the Target.provider field.

Fixed.

ibolton336 commented 2 weeks ago

Looks good! I've found one bug during smoke tests:

  1. filter by "Java" and select some cards
  2. go back in the wizard
  3. enter the target selection step again: filter is missing, cards cannot be de-selected

Looks like this bug shows up as a result of introducing checkboxes for unselected cards:

    isSelectable={!!cardSelected}

I'd like to fix this in another issue if possible. Need to investigate the PF component. Reverted the change for now & https://github.com/konveyor/tackle2-ui/issues/1252 will remain open.

rszwajko commented 1 week ago

@ibolton336 Integration tests are failing at selecting the card:

AssertionError: Timed out retrying after 8000ms: Expected to find element: `input[type="checkbox"]`, but never found it. Queried from:
              > cy.get(#target-card-Containerization)
ibolton336 commented 1 week ago

@ibolton336 Integration tests are failing at selecting the card:

AssertionError: Timed out retrying after 8000ms: Expected to find element: `input[type="checkbox"]`, but never found it. Queried from:
              > cy.get(#target-card-Containerization)

Fixed.