Closed ibolton336 closed 1 week ago
Attention: Patch coverage is 12.30769%
with 57 lines
in your changes missing coverage. Please review.
Project coverage is 42.73%. Comparing base (
b654645
) to head (cc9a731
). Report is 165 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
e2e ui testing is failing: https://github.com/konveyor/tackle2-ui/actions/runs/9504942845/job/26198861030?pr=1951#step:10:1822
First look makes sense, but there is an inconsistency with the Target.provider field.
Fixed.
Looks good! I've found one bug during smoke tests:
- filter by "Java" and select some cards
- go back in the wizard
- enter the target selection step again: filter is missing, cards cannot be de-selected
Looks like this bug shows up as a result of introducing checkboxes for unselected cards:
isSelectable={!!cardSelected}
I'd like to fix this in another issue if possible. Need to investigate the PF component. Reverted the change for now & https://github.com/konveyor/tackle2-ui/issues/1252 will remain open.
@ibolton336 Integration tests are failing at selecting the card:
AssertionError: Timed out retrying after 8000ms: Expected to find element: `input[type="checkbox"]`, but never found it. Queried from:
> cy.get(#target-card-Containerization)
@ibolton336 Integration tests are failing at selecting the card:
AssertionError: Timed out retrying after 8000ms: Expected to find element: `input[type="checkbox"]`, but never found it. Queried from: > cy.get(#target-card-Containerization)
Fixed.
Resolves https://github.com/konveyor/tackle2-ui/issues/1950
UI Tests PR: 1136
Needs: https://github.com/konveyor/tackle-ui-tests/pull/1136
Includes: