Closed rszwajko closed 1 week ago
Attention: Patch coverage is 30.43478%
with 32 lines
in your changes missing coverage. Please review.
Project coverage is 42.23%. Comparing base (
b654645
) to head (9f921e8
). Report is 169 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@JustinXHale @rromannissen @jortel Take a look at screenshots above - I've added 3 extra columns that looked very useful to me. They are initially hidden and can be enabled using column management dialog. Please let me know if you would rather remove them.
@JustinXHale @rromannissen @jortel Take a look at screenshots above - I've added 3 extra columns that looked very useful to me. They are initially hidden and can be enabled using column management dialog. Please let me know if you would rather remove them.
I think we're at the maximum number of columns we should be using, its borderline cramped. I think you've added relevant information. We could potentially save a little space using and provide some extra clarity using Relative Time or Timestamp
@JustinXHale
I think we're at the maximum number of columns we should be using,
Yep. The default columns take all space on a 1920x1080 screen. To show optional columns I had to hide some other columns.
We could potentially save a little space using and provide some extra clarity using Relative Time or Timestamp
Relative time makes harder to compare
started
withterminated
. Both dates are related but may end up in different "humanized" units. As for timestamp, it looks promising.
I agree with @JustinXHale 's remarks. Overall LGTM!
This looks great!
Functional changes:
Related features:
Resolves: https://github.com/konveyor/tackle2-ui/issues/1931