konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:sparkles: Add mvn:// prefix to application binary value in post request #1968

Closed ibolton336 closed 5 months ago

ibolton336 commented 5 months ago

Resolves: https://github.com/konveyor/tackle2-ui/issues/1967

Note: validation is not necessary since the ui already breaks up the input into separate for fields and composes the binary coordinates under the hood.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.73%. Comparing base (b654645) to head (e0543d8). Report is 166 commits behind head on main.

Files Patch % Lines
...s/components/application-form/application-form.tsx 33.33% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1968 +/- ## ========================================== + Coverage 39.20% 42.73% +3.53% ========================================== Files 146 166 +20 Lines 4857 5263 +406 Branches 1164 1263 +99 ========================================== + Hits 1904 2249 +345 - Misses 2939 2998 +59 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1968/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1968/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.73% <33.33%> (+3.53%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1968/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.