konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 40 forks source link

:bug: Update the enabled check for the Analysis button #1977

Closed sjd78 closed 3 months ago

sjd78 commented 3 months ago

On the application table, update the analysis button's enable/disable check such that analysis is only allowed to be started when all of the tasks for the selected applications are in a terminal state (they are not in-flight/queued).

Fixes: #1976

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.22%. Comparing base (b654645) to head (66a093d). Report is 174 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1977 +/- ## ========================================== + Coverage 39.20% 42.22% +3.01% ========================================== Files 146 170 +24 Lines 4857 5450 +593 Branches 1164 1325 +161 ========================================== + Hits 1904 2301 +397 - Misses 2939 3133 +194 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1977/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1977/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.22% <ø> (+3.01%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1977/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjd78 commented 3 months ago

Screen Shots

Analysis button enabled when the selected app doesn't have a task: screenshot-localhost_9000-2024 06 21-14_53_47

Analysis button disabled when one of the selected apps has a queued task: screenshot-localhost_9000-2024 06 21-14_53_55

Analysis button enabled when selected an app whose previous task is complete: screenshot-localhost_9000-2024 06 21-14_58_46