search

konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

Refactor useServerTasks() hook to allow reuse in both tasks page and tasks drawer #1995

Closed rszwajko closed 1 month ago

rszwajko commented 4 months ago

Remaining part of : https://github.com/konveyor/tackle2-ui/issues/1969 The proposal defined in this comment.

konveyor-ci-bot[bot] commented 4 months ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members.

sjd78 commented 4 months ago

/priority normal /triage accepted

sjd78 commented 4 months ago

@rszwajko -- I think you may have already handled this in #2004

rszwajko commented 4 months ago

@rszwajko -- I think you may have already handled this in https://github.com/konveyor/tackle2-ui/pull/2004

Re-using task actions is a parallel task. My understanding is that under this issue we want to achieve sth similar to DecoratedApplication

rszwajko commented 1 month ago

Task drawer switched to using the infinite scroller pattern which requires a dedicated data source : useInfinteServerTasks(). Therefore using a common hook is no longer possible.