codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 31.03448% with 20 lines in your changes missing coverage. Please review.
Project coverage is 42.11%. Comparing base (
b654645) to head (d061d53). Report is 193 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2011 +/- ## ========================================== + Coverage 39.20% 42.11% +2.90% ========================================== Files 146 171 +25 Lines 4857 5488 +631 Branches 1164 1311 +147 ========================================== + Hits 1904 2311 +407 - Misses 2939 3161 +222 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2011/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2011/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.11% <31.03%> (+2.90%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2011/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
Resolves: #1997
When a task is succeeded but has attached errors, render task state, application tasks state and application analysis state with a warning.
Details of Changes
With this change, hub is not adding a new terminal state, but having a new terminal state is an easy way to handle things. The task queries will now evaluate the
stateanderrorsprops to determine if "Succeeded" should be "SucceededWithErrors". This synthetic task status makes updating all of the UI component much simpler.To function properly, HUB Issue 725 / PR 720 are required.
Changes have also been made to utilize the
/tasks/reports/dashboardendpoint to get a much smaller view of tasks when dealing with them in aggregate.The application details drawer was refactored to push data fetching closer to actual use, and to break up a very large component into a container component with a component dedicated to each tab.
Screenshots
Application inventory page:
Application tasks popover:
Task Manager page: