konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:bug: [backport release-0.5] Persist filters in URL for applications table (#2033) #2038

Closed rszwajko closed 3 months ago

rszwajko commented 3 months ago

Backport-of: (#2033) Fix regression after: https://github.com/konveyor/tackle2-ui/pull/1980 Resolves: https://issues.redhat.com/browse/MTA-1390

Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state).

Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters.

Reference-Url: https://github.com/konveyor/tackle2-ui/pull/1698

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-0.5@0e579db). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-0.5 #2038 +/- ## ============================================== Coverage ? 42.33% ============================================== Files ? 172 Lines ? 5525 Branches ? 1359 ============================================== Hits ? 2339 Misses ? 3170 Partials ? 16 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2038/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2038/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.33% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.