search

konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 38 forks source link

Remove the use of @migtools/lib-ui #2044

Open sjd78 opened 1 month ago

sjd78 commented 1 month ago

There are a few places where types and functions from @migtools/lib-ui are used in the code. Since we're not maintaining the package anymore, we should drop it.

Additionally, dependencies from @migtools/lib-ui may cause issues. For example:

[sdickers@twilight tackle2-ui]$ npm why axios
axios@0.21.4 peer
node_modules/axios
  peer axios@"^0.21.2" from @migtools/lib-ui@10.0.1
  node_modules/@migtools/lib-ui
    @migtools/lib-ui@"^10.0.1" from @konveyor-ui/client@0.1.0
    client
      @konveyor-ui/client@0.1.0
      node_modules/@konveyor-ui/client
        workspace client from the root project

axios@1.6.8
client/node_modules/axios
  axios@"^1.6.8" from @konveyor-ui/client@0.1.0
  client
    @konveyor-ui/client@0.1.0
    node_modules/@konveyor-ui/client
      workspace client from the root project

We want axios@1.6.8 but axios@0.21.4 is still pulled in. Which npm is dealing with this situation ok, eventually the differences could start to cause problems.

konveyor-ci-bot[bot] commented 1 month ago

This issue is currently awaiting triage. If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members.