konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:sparkles: Add edit icon with ActionColumns property in the Archetypes table #2098

Closed Shevijacobson closed 1 month ago

Shevijacobson commented 2 months ago

Changes Made:

Part of #1318

Before the change:

Screenshot from 2024-09-29 10-24-26

After the change:

Screenshot from 2024-09-29 10-28-03

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.97%. Comparing base (b654645) to head (97e4355). Report is 239 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2098 +/- ## ========================================== + Coverage 39.20% 41.97% +2.77% ========================================== Files 146 175 +29 Lines 4857 5629 +772 Branches 1164 1415 +251 ========================================== + Hits 1904 2363 +459 - Misses 2939 3145 +206 - Partials 14 121 +107 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2098/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `41.97% <ø> (+2.77%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rszwajko commented 2 months ago

@mguetta1 It seems we have a general problem when multiple cells with isActionCell property are displayed - in list view (small screen) they get stacked (i.e. see below). Can you open an issue to track this? I think that with upgrade to newer PatterFly version we could solve it by using OverflowMenu as shown here image

mguetta1 commented 1 month ago

@mguetta1 It seems we have a general problem when multiple cells with isActionCell property are displayed - in list view (small screen) they get stacked (i.e. see below). Can you open an issue to track this? I think that with upgrade to newer PatterFly version we could solve it by using OverflowMenu as shown here image

An issue has been opened to address the above: #2111