Open Shevijacobson opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 41.98%. Comparing base (
b654645
) to head (e3b1f6f
). Report is 244 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good! Please attach some screenshots presenting the change and error message.
I have added screenshots that present the changes and the error message as requested.
Does the hub support file uploads of those types? What issue or ticket is this PR fixing? Is it #2112?
The hub currently only supports CSV files, so I handle the file format conversion in the UI. Now, supported file types (like Excel and OpenDocument) are converted to CSV in the UI before being uploaded to the server. This approach avoids needing to add additional format support on the server. Done in 9114f1e6c808bab70716c8acfafb473885a82ee6
The issue related is: https://github.com/konveyor/enhancements/issues/121 Regarding issue #2112 - we could not reproduce it.
adds support for uploading Excel (.xlsx, .xls) and OpenDocument Spreadsheet (.ods) formats in addition to CSV. It extends the file import functionality to support more common spreadsheet formats.
Before the Changes
Successful Upload of Supported File: This screenshot shows a successful upload of a CSV file, which was the only supported format in the original version.
Selecting an Unsupported File: Attempting to upload a file that is not in CSV format results in an error.
Error Message for Unsupported File: An error message is shown, as only CSV files were supported prior to this update.
After the Changes
Successful Upload of Supported File: The interface now accepts and processes files with .xlsx, .xls, and .ods extensions.
Selecting an Unsupported File: Attempting to upload a file that is still unsupported, triggering an error.
Error Message for Unsupported File: The system accurately displays an error when an unsupported file is chosen.
List of Uploaded Files with Supported Extensions: Successfully uploaded files, including .xlsx and .ods, now appear in the upload list.