search

koobo / HippoPlayer

HippoPlayer - a module player for the classic Amiga
MIT License
105 stars 18 forks source link

incorrect operation of the file requester #10

Closed evgenius123 closed 2 years ago

evgenius123 commented 2 years ago

when you double-click on a module in the built-in file requester, it starts playing not the clicked one, but the previous one. the selected one is highlighted in the list. sometimes it starts to play something junk

koobo commented 2 years ago

Some questions! Could you describe the exact steps to reproduce this? Also, does this happen always? Is this a new bug, that is, did it work in the v2.45 release for example? Do you have some patches running that modify the window visuals, such as the title bar height?

evgenius123 commented 2 years ago

I use Workbench 40.42, Kickstart 40.68, in multicolor mode (usually 32). no one program modify heights of titlebars. 1) I open Hippoplayer 2.50 2) I go to directory tree tab 3) I go to Media:MOD/ drawer (314 files, take 0.8 sec to open) 4) I open, for exmple, sixth file in list. It select sixth file, but move list up a little and highlited next module in list. 5) Now, if I select some file, program highlighted selected module, but starts playing previous one. 6) I can't play last module in list because of this issue.

koobo commented 2 years ago

Hi, I tried to reproduce this but failed. Here's what I did:

  1. Open Hippo v2.52
  2. Select file browser mode
  3. Open folder with about 400 files
  4. Select any module and play. Selected module plays correctly.
  5. Try to also play the last module. Also works.

I used three different ways to browse: pressing the enter key, double clicking with mouse, selecting item with mouse and then pressing the "Play" button.

Can you think of anything else that could be useful information? Does the problem only appear in filebrowser, not in the normal list view or favorites view?

evgenius123 commented 2 years ago

I never noticed this problem in playlist mode, and in "favorites" mode I just don't have so many modules) I notice this strange problem only in directory mode. What can I do to help to localize source of problem? Was some logs can be useful? From, idk, DOSTrace, for example?

koobo commented 2 years ago

Could you try to launch hip "without startup sequence" and see if the problem happens? This is to see if there are any other applications or patches that might affect.

Also it would be interesting to see a video about it, if possible.

koobo commented 2 years ago

I just noticed that if "Big buttons" is enabled it's not possible to double click on the last items in the list. Do you have "Big buttons" enabled?

evgenius123 commented 2 years ago

Where to find answer? never see this option. I can send you all folder of my mods, maybe this bug depends on specific modules? It appear from 5-th module on list, when first line, with folder name, scroll off, if "filebox" setting is "8"

evgenius123 commented 2 years ago

https://youtu.be/rtpnvx4wWzI here's link to video where bug is appear. not have my voice as sound, just short parts of modules and mouse clicking.

пн, 27 июн. 2022 г. в 07:22, Kari-Pekka Koljonen @.***>:

I just noticed that if "Big buttons" is enabled it's not possible to double click on the last items in the list. Do you have "Big buttons" enabled?

— Reply to this email directly, view it on GitHub https://github.com/koobo/HippoPlayer/issues/10#issuecomment-1166825585, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7G4LW6Z6L6CXEET5QSFZTVRET7FANCNFSM5N7OIEYA . You are receiving this because you authored the thread.Message ID: @.***>

koobo commented 2 years ago

Thank you for the video! I will see if I can make something out of it. "Big buttons" is an option in prefs, and according to the video you don't have it enabled, sorry about being unclear.

koobo commented 2 years ago

I'm guessing you have "play modules in random order" enabled in Prefs? I think the problem is related to that. In this mode each time a new module double clicked there will be an extra refresh to erase the random play markers in the list. There's a bug here that makes the list center, which it should not do actually.

evgenius123 commented 2 years ago

Yep, Goal! Bug disappear when I change "modules in random order" to "list repeatedly".

koobo commented 2 years ago

Could you try out this test version and see if the bug is fixed for you: https://github.com/koobo/HippoPlayer/blob/dev/dist/hip-test

evgenius123 commented 2 years ago

Yep, no issue in this build. Player do their work correctly, with "random order" file requester don't mess up with modules, and also plays it randomly. Thanks!

koobo commented 2 years ago

Ok, thanks for confirming 👍 I will include this fix in the next release.

koobo commented 2 years ago

Fixed in v2.53.