kosmolot-mods / geodesy

Geode Farm Design Tool
https://modrinth.com/mod/geodesy
MIT License
22 stars 6 forks source link

Minecraft 1.20.4 support. #13

Closed indaqoo closed 6 months ago

indaqoo commented 7 months ago

Hi,

WallMountLocation was renamed to BlockFace. This will fix the /geodesy analyze command issue with 1.20.4 versions.

kosma commented 7 months ago

Thank you ❤️ I will merge this soon, I need to take a good look at the version support situation.

ruben2s commented 6 months ago

Hi, any chance this is going to get published soon? Github actions seems to not have any build available to download regarding this change.

Thanks!

indaqoo commented 6 months ago

Hi, any chance this is going to get published soon? Github actions seems to not have any build available to download regarding this change.

Thanks!

Hi @ruben2s, I think you could clone this repo and build it yourself until @kosma has done all required version support checks, etc.

kosma commented 6 months ago

Fixed in 61b9264. Couple of notes:

  1. The offending change wasn't the rename of WallMountLocation to BlockFace (that's a Yarn named rename, those are harmless), it was a hard to explain intermediary rename of Blocks.PUMPKIN from field_10261 to field_46282. Go figure.
  2. The change was done in 1.20.3 but the mod works on both .3 and .4 now.