kreghek / Zilon_Roguelike

Survival roguelike game with huge world generation.
MIT License
27 stars 15 forks source link

Feature 1164 two handed weapon mechanics #1205

Closed kreghek closed 3 years ago

kreghek commented 3 years ago

Resolves #1164

Changes

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #1205 (e7049cd) into master (42d106c) will increase coverage by 0.14%. The diff coverage is 77.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   63.35%   63.50%   +0.14%     
==========================================
  Files         347      347              
  Lines        7901     8006     +105     
==========================================
+ Hits         5006     5084      +78     
- Misses       2895     2922      +27     
Flag Coverage Δ
Zilon.Core.FunctionalTests 40.06% <56.48%> (+0.17%) :arrow_up:
Zilon.Core.UnitTests 48.61% <54.19%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/Zilon.Core/PersonModules/EquipmentModuleBase.cs 90.32% <ø> (ø)
...lon.Core/Zilon.Core/Schemes/PersonSlotSubScheme.cs 0.00% <0.00%> (ø)
...on.Core/Zilon.Core/Commands/Sector/EquipCommand.cs 74.71% <68.00%> (-10.40%) :arrow_down:
...lon.Core/Zilon.Core/Tactics/Behaviour/EquipTask.cs 85.36% <83.33%> (-10.94%) :arrow_down:
...n.Core/Zilon.Core/PersonModules/EquipmentModule.cs 90.47% <100.00%> (+7.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42d106c...e7049cd. Read the comment docs.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 965011639


Changes Missing Coverage Covered Lines Changed/Added Lines %
Zilon.Core/Zilon.Core/Schemes/PersonSlotSubScheme.cs 0 2 0.0%
Zilon.Core/Zilon.Core/Tactics/Behaviour/EquipTask.cs 55 66 83.33%
Zilon.Core/Zilon.Core/Commands/Sector/EquipCommand.cs 34 50 68.0%
<!-- Total: 102 131 77.86% -->
Files with Coverage Reduction New Missed Lines %
Zilon.Core/Zilon.Core/Commands/Sector/EquipCommand.cs 1 72.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 962717650: 0.1%
Covered Lines: 5084
Relevant Lines: 8006

💛 - Coveralls
sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kreghek commented 3 years ago

Rules of equipment are described in the page https://github.com/LAST-IMPERIAL-VAGABOND/LAST_IMPERIAL_VAGABOND.github.io/blob/main-2-5-8/rules/persons.md