[BUG] "Rush sword's" ability "Super hit" do not recover over time

kreghek / Zilon_Roguelike

Survival roguelike game with huge world generation.

MIT License

27 stars 14 forks source link

[BUG] "Rush sword's" ability "Super hit" do not recover over time #974

Open kreghek opened 3 years ago

kreghek commented 3 years ago

Describe the bug This hit has cooldown. It means hit must be available over time. But it does not restored.

To Reproduce Steps to reproduce the behavior:

Find The Sword of Rush.
Equip sword in offhand as second weapon.
Select super hit and use it on the monster.
Walk around about 100 steps.
Hit on action panel is not available.

Expected behavior Actions with cooldown must be available over time. It goot to show approximate time of cooldown.

Additional context The issue in the action panel I think. First look on Unity Client.

kreghek commented 3 years ago

Error happened because new instance of tactical act created every module request. And Unity Client holds the one of the instances. But every sector's update create empty new instance with zero CD.

Possible solutions:

Keep unique instances for all actons and give it via property. Inside of the module sync of instances will perform every event like effect/equipment/perk update.
Keep separated info about CD. And a lot of instances will found their info items and calculate own state.

kreghek commented 3 years ago

Keep unique instances for all actons and give it via property. Inside of the module sync of instances will perform every event like effect/equipment/perk update.

Effects work similarly.